final corrections before submission
This commit is contained in:
+2
-3
@@ -56,6 +56,5 @@ with open('type_effectiveness.json', 'r') as file:
|
||||
type_effectiveness.append(json.loads(line))
|
||||
type_effectiveness_df = pd.DataFrame.from_dict(type_effectiveness)
|
||||
#NOTE: from a practical point of view, since type_effectiveness is accessed many times
|
||||
#in the main code, using pandas DataFrame is not efficient. I decided to keep using dictionaries
|
||||
#for the type effectiveness. The justification arises especially if we consider
|
||||
#how long data generation will take.
|
||||
#in the main code I decided to keep using dictionaries
|
||||
#for the type effectiveness
|
||||
Reference in New Issue
Block a user